-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dynamic upStreamCodes option #618
Conversation
e4e20f1
to
1167c30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default upstream codes should be an empty array, it never makes sense for this code to retry. Let the application always decide what to do by default
@hersentino this looks good! Can you run @doctorpangloss yeah, I buy that; @hersentino are you fine making a change to also make this default to an empty list? Thanks! |
@stephenh all done :) |
Thanks @hersentino ! |
# [1.118.0](v1.117.1...v1.118.0) (2022-07-19) ### Features * add dynamic upStreamCodes option ([#618](#618)) ([3091023](3091023))
🎉 This PR is included in version 1.118.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR introduces dynamic upStreamCodes option following discussions on #539