-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toJSON methods don't respect useDate=false #935
Comments
Huh, I was a little surprised toJSON doesn't check for Fwiw @roboslone if you could submit a PR for this, that'd be great! Maybe find an integration test that has a Thanks! |
Sure, I'll give this a try. |
I noticed it today too, and it's really strange that no one had spotted it yet |
I could revert this change after I'm finished with this issue, or I could keep it so more people are able to run tests. @stephenh What do you think? |
Kept base image change for now, let me know if you want it reverted. |
🎉 This issue has been resolved in version 1.159.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Might I argue this a bad/wrong fix for the non-issue?
This fix completely breaks the gRPC agenda of any language any platform compatibility, as protojsons can now be ts-proto compatible only I believe there was a reason why useDate didn't apply to json representations. We have a JVM/Python/Node JS ecosystem and we used I think we should parameterize this option, or create another param ( |
This leads to precision loss.
I'm using
useDate=false
, which affects generated objects, but doesn't affecttoJSON
method.The text was updated successfully, but these errors were encountered: