fix: camelToSnake to respect uppercase words, such as "GetAPIValue" -> "GET_API_VALUE" #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonArmand
changed the title
|
Hi @BrandonArmand , thanks for the PR! Can you remove the |
|
Fwiw my guess is that the build failures are because a dependency like ts-poet or prettier accidentally got unlocked/bumped to latest with the package-lock/yarn.lock changes. |
|
Removed |
|
Looks great! Thanks! |
stephenh
pushed a commit
that referenced
this pull request
May 25, 2024
## [1.176.1](v1.176.0...v1.176.1) (2024-05-25) ### Bug Fixes * camelToSnake to respect uppercase words, such as "GetAPIValue" -> "GET_API_VALUE" ([#1046](#1046)) ([d2e75cd](d2e75cd))
|
🎉 This PR is included in version 1.176.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
camelToSnake()is converting the example string "TestAPI" -> "TEST_AP_I" when converting a 3rd party integration proto files that I am attempting to generate with the Nest option. I believe that the conversion should respect the "API" part of the string and not split it into two parts like so.Fix
I swapped the logic to use the already imported "case-anything" library's
snakeCase()function assnakeCaseAnything()and added a couple of simple tests to ensure the logic.I would love for this fix to go through as it is a pretty inconvenient problem at the moment (:
Thanks!