feat: no-file-descriptor setting for outputSchema option
#1047
+313
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stephenh I've noticed these diffs being generated even on main. Can you confirm whether you experience this too? Or... maybe its just an issue when I run on my machine. |
lukealvoeiro
force-pushed
the
lalvoeiro/no-file-descriptor-in-output-schema
branch
from
4555740
to
9bc8691
Compare
|
@lukealvoeiro yeah, I had noticed it failing on |
lukealvoeiro
force-pushed
the
lalvoeiro/no-file-descriptor-in-output-schema
branch
from
9bc8691
to
72b4e87
Compare
stephenh
pushed a commit
that referenced
this pull request
Jun 7, 2024
# [1.178.0](v1.177.0...v1.178.0) (2024-06-07) ### Features * `no-file-descriptor` setting for outputSchema option ([#1047](#1047)) ([c54f06c](c54f06c))
|
🎉 This PR is included in version 1.178.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
timostamm
added a commit
to timostamm/ts-proto
that referenced
this pull request
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the outputSchema setting is enabled, it generated an object containing a
fileDescriptorentry. Depending on the proto file, the associated value can be very large. This PR allows consumers ofts-prototo reap the benefits of the output schema, while minimizing the overall size of the object by removing thefileDescriptorentry.Testing