-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adding a failing regression test for wrapper types #689
Conversation
So #534 introduced a unique way of handling Timestamps. That incredibly complicates things and I believe should be reverted. The problem at the moment is that while we're great at Given the current state, we should default to "no magic", rather than "deeply broken magic." |
Also, I have no idea why the test bin generation is inconsistent with upstream. 😬 |
I haven't looked into the rest of this yet, but that's typically due to different versions of Hopefully that works? Ah, in #534 you mention you're using an M1; I wonder if our docker build needs to also specify the platform as x86 (which M1 would run emulated afaiu) to get the |
@fizx fwiw I pushed the |
## [1.131.2](v1.131.1...v1.131.2) (2022-11-13) ### Bug Fixes * Adding a failing regression test for wrapper types ([#689](#689)) ([bde2e28](bde2e28))
🎉 This PR is included in version 1.131.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
If a GRPC service returns a wrapper type (e.g. StringValue), everything breaks. This used to work in 1.110.2 at least. I'm investigating the cause. Feels related to #534, but the solution is quite unclear as yet.