Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): update plugin reference #820

Merged
merged 4 commits into from
May 2, 2023

Conversation

mfridman
Copy link
Contributor

@mfridman mfridman commented May 2, 2023

Hey there, I dropped a comment earlier but figured I'd also update the README to point at the updated plugin. The source of this plugin is in this repository:

https://github.com/bufbuild/plugins

And published on buf.build on the plugin page: community/stephenh-ts-proto

@@ -110,7 +110,7 @@ You can also use the official plugin published to the Buf Registry.
```yaml
version: v1
plugins:
- remote: buf.build/stephenh/plugins/ts-proto
- plugin: buf.build/community/stephenh-ts-proto
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newer versions of the buf CLI will use the plugin key for both local and remote plugins.

@mfridman mfridman changed the title Update plugin reference docs(readme): update plugin reference May 2, 2023
@mfridman
Copy link
Contributor Author

mfridman commented May 2, 2023

I can also remove the old push_to_buf_registry job in .github/workflows/build.yml as well as ts-proto.Dockerfile if you'd like.

@stephenh
Copy link
Owner

stephenh commented May 2, 2023

Ah great! Thanks for the PR @mfridman ! I'm just scanning it while in between things, but really appreciate the update.

I can also remove the old push_to_buf_registry job in .github/workflows/build.yml as well as ts-proto.Dockerfile if you'd like.

Yeah, that'd be great, thanks!

@mfridman
Copy link
Contributor Author

mfridman commented May 2, 2023

Updated.

The nice thing is you don't have to worry about the ceremony around packaging, testing, and deploying the plugin to buf.build. It's all automated from our side for popular community plugins via github.com/bufbuild/plugins.

Let us know if you have any questions or concerns. More than happy to help! 😄

@stephenh
Copy link
Owner

stephenh commented May 2, 2023

Erm, shoot... Sorry @mfridman , I was moving too quickly and am now 2nd guessing myself; can we keep the ts-proto.Dockerfile? I believe we have some community members who use it in their own setups.

@mfridman
Copy link
Contributor Author

mfridman commented May 2, 2023

Erm, shoot... Sorry @mfridman , I was moving too quickly and am now 2nd guessing myself; can we keep the ts-proto.Dockerfile? I believe we have some community members who use it in their own setups.

Sure thing, reverted in 0660cd0

@stephenh
Copy link
Owner

stephenh commented May 2, 2023

Sweet, thanks @mfridman !

@stephenh stephenh merged commit e60706b into stephenh:main May 2, 2023
1 check passed
@stephenh
Copy link
Owner

stephenh commented May 7, 2023

🎉 This PR is included in version 1.147.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants