Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stephenhillier I started working on the update discussed in #82 and I am going with
__unknown__
value in the end as the_
symbol is unlikely to conflict with some actual api endpoint.As I was finishing up the changes, it seemed quite impractical to support both
filter_unhandled_paths
andgroup_unhandled_paths
options as only one of these is applicable. It leads to weird situations like, if you want to enablegroup_unhandled_paths
you also need to explicitly disablefilter_unhandled_paths
as it is enabled by default. Maybe 2 different flags are not the right way to go? Maybe an option likeunhandled_paths_strategy
accepting string valuesignore
(replacement forfilter_unhandled_paths
),group
(replacement forgroup_unhandled_paths
), orunique
(replacement for setting bothfilter_unhandled_paths
andgroup_unhandled_paths
toFalse
, but not sure about the nameunique
) to decide how to handle these situations. I think this would be a better way to go, but if we remove thefilter_unhandled_paths
, it will be a breaking change.If we go with
unhandled_paths_strategy
option, the default value could be actually based ongroup_paths
option. If enabled, the default value would begroup
, if disabled, default value could beunique
.If we go with
group_unhandled_paths
option, what should happen if bothfilter_unhandled_paths
andgroup_unhandled_paths
are set toTrue
? I threw an error, but I am not sure if thats the right way to go.I pushed the original solution as a draft and we can discuss which direction we should go.
Going with a new flag would be least disruptive to users as it does not introduce any breaking changes, but seems quite unintuitive when setting up the configuration (disabling one flag to be able to enable another one).