Optionally inject Request to exemplars function. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspect the exemplars function and pass the Request object, if a parameter with type annotation Request exists OR if no such parameter exists but one with the name "request". Fixes stephenhillier#90
|
This is great. Does the annotation attribute require a minimum Python version? The tests seem to cover all the cases I can think of and they are passing under 3.8, so I think we're good. |
|
I should have got this in before I cut a release this morning, but I will try to do another one tonight or within the next few days. |
|
Cool! Thanks! AFAIK, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspect the exemplars function and pass the Request object, if a parameter with type annotation Request exists OR if no such parameter exists but one with the name "request".
Fixes #90