Fix issue #188 #189
Merged
Fix issue #188 #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When '-a' is set in opt.args, opt.disableAppendPaths has to be set to 'true' too. Wrap appending the default ' .' path to the commit command accordingly to re-allow the use of '-a' as argument to the 'git commit' command.
|
Do you want to edit the git config on your system to use your github email? right now it shows the "unknown user" |
|
Ah. Sorry for that. Let me take care of it |
|
Hi,
I’ve configured user.name and user.email on my local system for the fork of gulp-git. Anything else? I’m not sure what will be the next step? If I look at the pull request in GitHub, thinks seems to be OK.
Best regards
Uwe Stieber
… Am 26.07.2018 um 19:45 schrieb Steve Lacy ***@***.***>:
Do you want to edit the git config on your system to use your github email? right now it shows the "unknown user"
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#189 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFRO3s38akzqawtFW9C9BzgvzpR8F1Upks5uKgAwgaJpZM4VhaeU>.
|
|
You can now do |
Fix indentation of change in commit.js
|
Did it.
Best regards, Uwe
… Am 27.07.2018 um 17:37 schrieb Steve Lacy ***@***.***>:
You can now do git commit --amend --author="Author Name ***@***.***>"
Then force push to your branch fix_issue_188
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#189 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFRO3jcpE4Mot2DBNjeKvDYKQW9fZRu8ks5uKzOvgaJpZM4VhaeU>.
|
|
Perfect, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my proposed fix for issue #188 . Please review and merge if the fix is OK for you.