This repository has been archived by the owner on Aug 5, 2022. It is now read-only.
Fix app option after switch to opn
#34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent, thanks! |
|
I noticed though that the tests aren't really useful. They check that opening doesn't return an error, but there's no way to make sure anything actually opened. |
|
Yeah, the only tests I could think of involve running |
|
This solves the issues reported in #33 for me. Thanks @TheDancingCode ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should correctly implement the
appoption again, after the switch fromopentoopnin #32. I ran all the examples and got identical results compared to the previous behaviour. I apologize for the incorrect implementation earlier.Closes #33.