Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix socketio import error #78

Merged
merged 1 commit into from May 8, 2015

Conversation

dxe4
Copy link
Contributor

@dxe4 dxe4 commented May 8, 2015

i think this changed at some point

from socketio import SocketIOServer
ImportError: cannot import name SocketIOServer

@dxe4
Copy link
Contributor Author

dxe4 commented May 8, 2015

it looks like the failing tests are because of updated requirements i think pip install . gets django 1.8.
i'll try to fix it at some point tomorrow.

@stephenmcd
Copy link
Owner

Thanks. I'll merge this but you should be aware this library is woefully out of date.

Issue #19 contains a lengthy discussion describing what needs to happen. If you do intend to put any effort into this library, I'd strongly suggest focusing on that rather than anywhere else.

Thanks again!

@stephenmcd
Copy link
Owner

BTW if you can let me know when you're done with everything you want to look then I can push a new patch release to PyPI.

@stephenmcd stephenmcd merged commit 3d204a3 into stephenmcd:master May 8, 2015
@dxe4
Copy link
Contributor Author

dxe4 commented May 8, 2015

yes this was meant to be the start to get the server running with latest gevent-socketio, i will attempt to get it working but i can't guarantee. At least if the server starts others can contribute. @krishn2014 mentioned he could contribute.

The tests passed locally on this one but because the repo wasn't updated for a while the tests broke anyway, i think if you run the latest master before this on travis will still fail

@stephenmcd
Copy link
Owner

No problem at all! There's no obligation of course, just wanted to make sure your efforts weren't misdirected :-)

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants