Replace _get_val_from_obj with value_from_object #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 27, 2021
|
🎉 This PR is included in version 5.0.0-rc.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
aparakian
reviewed
Sep 30, 2021
| @@ -94,7 +94,7 @@ def validate(self, value, instance): | |||
| raise ValidationError(error) | |||
|
|
|||
| def value_to_string(self, obj): | |||
| value = self._get_val_from_obj(obj) | |||
| value = self.value_to_string(obj) | |||
There was a problem hiding this comment.
Typo? Wasn't it supposed to be value_from_object?
There was a problem hiding this comment.
It was suppose to be value_from_object. The change made now causes an infinite recursion when serializing the field (for example, with dumpdata).
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1977, I believe this functionality was just duplicated functionality and the method has been replaced.
See https://code.djangoproject.com/ticket/24716 for more info