Smart Light-Dark mode detection #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use case is where user has already chosen a Dark Mode preference (ie macOS/iOS) and site start in white mode killing your eyes. This will make the site smart enough to detect that preference and switch the Dark Mode on. Nothing critical changed. Could be improved to let site author chose if they want to turn this feature on/off (based on style preferences).
|
Already being tested here |
stephenou
requested changes
Sep 8, 2020
Fixing typo in comment at stephenou#256 (basded) and fixing function invoking at stephenou#265 (toggl())
stephenou
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case
When user has already chosen a Dark Mode preference (ie macOS/iOS) and site start in white mode killing your eyes. This will make the site smart enough to detect that preference and switch the Dark Mode on.
Nothing critical changed.
Next steps
Could be improved to let site author chose if they want to turn this feature on/off (based on style preferences).