-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vignette does not use correct V #18
Comments
building on this, probably we need to update defaults etc in light of new work. I suggest we require the user to specify a number of components rather fit0 <- ud_init(X,n_unconstrained = 10,V = V) and this would fit a mixture with 10 unconstrained components. |
Yes. The default has to be changed, as we don't encourage the use of rank-1 Us. How about canonical Us? |
on canonical Us, we don't discourage, but they should not be included as default. They are an "additional feature". |
I updated the udr_intro vignette and changed the default setting to n_rank = 0. I think this issue can be closed now. |
in https://stephenslab.github.io/udr/articles/udr_intro.html
the initial run uses the "default" V=Identity whereas the true V is
different. That's not something we want to encourage I think....
The text was updated successfully, but these errors were encountered: