Add support for templated dashboards #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work! Tagging a release shortly. |
stephenyeargin
added a commit
that referenced
this pull request
Jun 25, 2015
Add support for templated dashboards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised.
I have implemented as I mentioned in #7 by splitting everything following the
slug:pidpart of the command depending on if there's a=in the word or not. All words which contain an=are added to the parameters list withvar-prepended, and the ones not containing a=are assigned to the "from" and "to" fields in order, until they both are assigned. The rest is just discarded.There's no URL encoding of the variables currently. I don't necessarily think that's a big problem, since stuff like spaces never should occur in a Graphite query, I would think.