Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return all matching panels rather than just one #142

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

stephenyeargin
Copy link
Owner

Fixes #141

@stephenyeargin
Copy link
Owner Author

@yohey03518 If you have a moment to test:

    "hubot-grafana": "stephenyeargin/hubot-grafana#bug-141/return-more-than-one-panel",

@yohey03518
Copy link

Hi @stephenyeargin, code was looked good! But sorry I can not find this version stephenyeargin/hubot-grafana#bug-141/return-more-than-one-panel on neither npm nor github npm.
It would cause npm install fail with fail reason This is related to npm not being able to find a file.
I am not very familiar with npm flow, maybe could provide some more tips for me to test?
Thanks again.

@stephenyeargin
Copy link
Owner Author

Sure, so it's a feature of NPM (at least as of v8) that you can specify a <github user>/<repository>#<branch> instead of a semantic version to load it directly from GitHub instead of the registry. Looking around the internet, it looks like it may not work in every circumstance.

I'm also comfortable with tagging a version. I'm reasonably sure this is in good shape.

@yohey03518
Copy link

I have verified my build env is using npm 8.1.0 but still get same result. Maybe I need more time to study this new feature.
It's good if you can help to tag a version for this. :)
Thank you.

@stephenyeargin stephenyeargin merged commit fbe67a6 into master Jan 31, 2022
@stephenyeargin stephenyeargin deleted the bug-141/return-more-than-one-panel branch January 31, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can only receive 1 image by each query which queries all panels in the dashboard
2 participants