Grafana v5.0 support #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #66 This refactors the process by which the Hubot package locates the relevant data in the API response. The original issue came from the elimination of the `rows` property, replacing it with a coordinate system instead. Note that this will also drop support for versions < 2.0.2 to keep the code a bit cleaner. Users should pin to `v1.8.0` if you are using an older version of Grafana.
stephenyeargin
added a commit
that referenced
this pull request
Apr 4, 2018
The changes in #67 needed to be cleaned up a bit. - Splits the v4 and v5 tests into separate files - Moves the relevant JSON fixtures into subfolders
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66
This refactors the process by which the Hubot package locates the relevant data in the API response. The original issue came from the elimination of the
rowsproperty, replacing it with a coordinate system instead.hubot-grafana/src/grafana.coffee
Lines 141 to 152 in 81345c0
Note that this will also drop support for versions < 2.0.2 to keep the code a bit cleaner. Users should pin to
v1.8.0if you are using an older version of Grafana.