Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Cache File Type Extentions #1476

Closed
SpoOkyMagician opened this issue Jun 8, 2017 · 3 comments
Closed

FR: Cache File Type Extentions #1476

SpoOkyMagician opened this issue Jun 8, 2017 · 3 comments

Comments

@SpoOkyMagician
Copy link

SpoOkyMagician commented Jun 8, 2017

I discussed this on IRC and while it's only a windows things, I recommend having something as the file extension for the cache. In windows, it's just a garbled mess. (By Default, they are "file") I recommend ending it with something like...

.cache
.cach
.cah

or something along those lines. (Preferable a 3 character ending. Which is the standard for Windows.)

@tertu-m
Copy link
Contributor

tertu-m commented Jun 8, 2017

there's no reason that windows has to have 3-character extensions, you could do .sm5-cache if you wanted

@concubidated
Copy link
Member

Should be a super simple change, but is there really any reason though? This shouldn't even be a directory users should have to go into at all.

Something like this in Song.cpp

std::string Song::GetCacheFilePath() const
{
	return SongCacheIndex::GetCacheFilePath( "Songs", m_sSongDir+".cache" );
}

Didn't look if anywhere else would need it.

@concubidated
Copy link
Member

Closing, either PR will get merged or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants