Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Only A+ or better (except if we lose there is always F) #1717

Closed
latot opened this issue Jul 17, 2018 · 4 comments
Closed

All Only A+ or better (except if we lose there is always F) #1717

latot opened this issue Jul 17, 2018 · 4 comments
Assignees

Comments

@latot
Copy link
Contributor

latot commented Jul 17, 2018

Hi, i notice now all evaluations in stepmania are A+, or AA, or AA+, or something like that, B, C, D and A are missing...

Here i miss a lot, and still i'm getting A+.

2018-07-17_093720

Cya.

@quietly-turning
Copy link
Contributor

The default theme for the 5_1-new branch doesn't define its own GradeTier metrics under [PlayerStageStats], so it inherits what the _fallback theme defines here.

The _fallback theme defines 7 GradeTiers, and GradeDisplay Grade Grade_Tier07.png is, in fact, an "A" grade. Interestingly, the default theme has graphics for 17 grades, though 8 through 17 are not currently used.

@ListenerJubatus
Copy link
Contributor

This was a Lambda oversight relevant to all branches.

I put the ITG ranking tiers from SL in on both 5.2 and 5.1, so it should be correct now.

@quietly-turning
Copy link
Contributor

Oversights happen; thanks for taking care of it, @ListenerJubatus! 🙂

@ListenerJubatus ListenerJubatus self-assigned this Jul 17, 2018
@ListenerJubatus
Copy link
Contributor

stepmania_2018-07-17_14-39-31
and some visual proof of the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants