Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unix user directory name hard-coded #1912

Open
coderjo opened this issue Oct 6, 2019 · 2 comments
Open

Unix user directory name hard-coded #1912

coderjo opened this issue Oct 6, 2019 · 2 comments

Comments

@coderjo
Copy link
Contributor

coderjo commented Oct 6, 2019

In ArchHooks_Unix.cpp, the user data directory name is hardcoded. Is there a reason it isn't deriving from PRODUCT_ID, like the other OSes?

On the current 5_1-new, it is "stepmania-5.1", but on master (which some people seem to be using), it is still "stepmania-5.0" rather than 5.2.

@shakesoda
Copy link
Member

oversight from when it was just "stepmania"

another issue is that we should be checking env for XDG_DATA_HOME (typically ~/.local/share), possibly also XDG_CONFIG_HOME (typically ~/.config) and using that value as the base directory for save data, and not just home dir. ~/.stepmania should be last resort if we can't use xdg dirs

the right thing to do, technically, would be to write preferences into xdg_config_home, but in practice we've always gotten complaints about splitting this kind of stuff up, so i'd rather leave things in xdg_data_home

@coderjo
Copy link
Contributor Author

coderjo commented Oct 6, 2019

If we move to using the XDG spec, the Cache directory should use XDG_CACHE_HOME

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants