Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default EditText color #13

Closed
anastr opened this issue Aug 29, 2017 · 3 comments
Closed

default EditText color #13

anastr opened this issue Aug 29, 2017 · 3 comments

Comments

@anastr
Copy link

anastr commented Aug 29, 2017

the default EditText background color is white !
it is annoying when i have dark theme (commentBackgroundColorResId and commentTextColorResId is white!!)
@pglebocki
Copy link
Contributor

Hi Anastr,

Thank You very much for feedback.
I will change it in next release (1.3). Edit text background color will inherit from theme's "colorAccent" by default, so it is not be white anymore.
For now you can set properties programically by "setCommentTextColor" and "setCommentBackgroundColor "

BR,
Piotr

@anastr
Copy link
Author

anastr commented Aug 31, 2017

looks great.
i suggest to add setCommentHintText(String/ res) method, it will be nice.

pglebocki added a commit that referenced this issue Sep 1, 2017
@pglebocki
[issue #13] Implemented support for custom hints (text/color) (#17)
d440476 
* added support for hints (custom text and color)

* updated change log

* corrected javadocs

* updated readme
@pglebocki
Copy link
Contributor

We released version 2.0.
It contains fixed for this issue and additionally has api for customise hints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pglebocki @anastr