Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI + minor changes #11

Merged
merged 15 commits into from
Jul 24, 2022
Merged

GUI + minor changes #11

merged 15 commits into from
Jul 24, 2022

Conversation

stepva
Copy link
Owner

@stepva stepva commented Jul 24, 2022

contains everything from @miskfi

  • keep CLI as an option with optional argparse
  • have current directory as the default in the GUI when selecting a directory

miskfi and others added 15 commits July 20, 2022 00:29
miskfi
miskfi reviewed Jul 24, 2022
View reviewed changes
Copy link
Collaborator

@miskfi miskfi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a big fan of the formatting changes, especially the if statements (for example in the method create()). Ideally keep formatting as was and then agree on some code style and formatting standard - this applies just to the changes made in GUI.py

miskfi
miskfi approved these changes Jul 24, 2022
View reviewed changes
Copy link
Collaborator

@miskfi miskfi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, it would be nice to have the CLI/GUI as polymorhpic objects in the program but this is ok for now

@stepva stepva mentioned this pull request Jul 24, 2022
Closed
@stepva stepva merged commit 347ae78 into master Jul 24, 2022
@stepva stepva deleted the gui branch July 24, 2022 15:05
@stepva stepva linked an issue Jul 24, 2022 that may be closed by this pull request
Basic GUI #7
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miskfi miskfi miskfi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Basic GUI
2 participants
@stepva @miskfi