Add --no-follow flag to exit when all logs have been shown #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tksm
commented
Jan 13, 2023
Comment on lines
+77
to
+79
| filter.visit(pod, func(t *Target, containerStateMatched bool) { | ||
| removed <- t | ||
| }) |
There was a problem hiding this comment.
Containers without their statuses are never added, so now we get container names from container statuses in the same manner as handling Added/Modified events to simplify the logic.
superbrothers
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15
This PR adds
--no-followflag to exit when all logs have been shown.The name of the flag could be
--follow=false. But it will be used withfalsein most cases, so I chose--no-followas the auto-completion can work in one shot.