-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support resuming from the last log when retrying #230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tksm
requested review from
superbrothers,
floryut and
rkmathi
as code owners
February 17, 2023 05:36
I'll check this PR this weekend. |
Co-authored-by: Kazuki Suda <230185+superbrothers@users.noreply.github.com>
superbrothers
approved these changes
Feb 18, 2023
stern/stern.go
Outdated
return NewTail(client.CoreV1(), t.Node, t.Namespace, t.Pod, t.Container, config.Template, config.Out, config.ErrOut, &TailOptions{ | ||
Timestamps: config.Timestamps, | ||
Location: config.Location, | ||
SinceSeconds: int64(config.Since.Seconds()), | ||
SinceSeconds: &sinceSeconds, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to use k8s.io/utils/pointer
here.
Suggested change
SinceSeconds: &sinceSeconds, | |
SinceSeconds: pointer.Int64(int64(config.Since.Seconds())), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed it in 51f9032 👍
Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #229
This PR is to support resuming from the last log when retrying.
Here is the summary of the changes.
I found the rate limiter of retrying was not appropriate while I tested this feature, so I also tweaked it.
How to test
The below steps are the way to test the resuming feature by restarting the kube-apiserver.
If you use kind, you can restart the kube-apiserver by the command below.
The connection will be disconnected, but it will retry soon and resume logs from the last line.