Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support relative paths in gophermaps #22

Closed
sternenseemann opened this issue Dec 28, 2020 · 2 comments
Closed

Support relative paths in gophermaps #22

sternenseemann opened this issue Dec 28, 2020 · 2 comments
Labels
bug

Comments

@sternenseemann
Copy link
Owner 

       selector
              The  selector  is  the  name  of  the file on the server.  If it
              begins with a slash, it is an absolute path;  otherwise,  it  is
              interpreted relative to the directory that the gophermap file is
              in.  If no selector is specified, the description is  also  used
              as the selector.

spacecookie currently interprets relative selectors wrong.
sternenseemann added a commit that referenced this issue Dec 28, 2020
@sternenseemann
feat(Network.Gopher.Util.Gophermap): detect relative paths properly
6dda0fa 
Also reflect and implement in server executable.

Resolves #22.

BREAKING CHANGES:

* GophermapEntry uses GophermapFilePath instead of FilePath
* gophermapToDirectoryResponse now takes an extra argument describing
  the directory relative from the root of the gopher space the gophermap
  is located in
@sternenseemann
Copy link
Owner Author

cc @hyperrealgopher

This might be interesting for Burrow: Gophermaps now support relative URLs, meaning spacecookie may spare you some path mangling.

@hyperrealgopher
Copy link

Thank you for notifying me about this. I'll keep that in mind!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sternenseemann @hyperrealgopher