fix(Network.Gopher): give client time to close client socket; refactor haskell-socket utilities #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move file descriptor conversion into top level bindings, throw IOExceptions on errors and document them. SystemdException no longer contains the invalid file descriptor exception.
Mimic the behavior of 'close' in toFd: replace the old file descriptor with (-1). This ensures that further calls on the 'Socket' are “safe” in a sense as they won't block indefinetely. Instead they will throw an exception as if close was called on the Socket.
After sending the response, we now send TCP FIN by calling shutdown(2) on the socket. We then wait up to 1 second for the client to finish reading and closing the socket on their end before finally closing the socket on our side. This prevents read broken pipes for clients like curl which would occasionally happen. Resolves #42.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.