Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0.0-beta.74 fix router params #189

Merged
merged 1 commit into from Aug 28, 2023
Merged

Conversation

devmartynov
Copy link
Contributor

@devmartynov devmartynov commented Aug 24, 2023

Как воспроизвести:

  1. Добавить два маршрута. Один обычный другой с ролью role=ROUTER_ROLE_MODAL
[ROUTE_BOOK_DICTIONARY]: {
    exact: false,
    path: 'book/dictionary',
    component: DictionaryPage,
    label: __('Словарь'),
    roles: permissions,
    items: {
        [ROUTE_BOOK_DICTIONARY_ARTICLE]: {
            exact: false,
            path: 'book/dictionary/:articleId',
            role: ROUTER_ROLE_MODAL,
            component: ArticleModal,
            label: __('Статья'),
            roles: permissions,
        },
    }
},

Что делаю:

  1. Перейти с маршрута book/dictionary на book/dictionary/1
  2. Нажать системную кнопку "назад" в браузере.

Что ожидаю:

Маршрут изменяется с book/dictionary/1 на book/dictionary

Что происходит:

Маршрут изменяется с book/dictionary/1 на book/dictionary?articleId=1

@Daria-Kuzminykh Daria-Kuzminykh merged commit 73a0b53 into master Aug 28, 2023
2 checks passed
@Daria-Kuzminykh Daria-Kuzminykh deleted the fix_router_params branch January 19, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants