Fix addVector bug. Fixes #22.

stevage · Apr 11, 2021 · 7d13e64 · 7d13e64
1 parent 23da831
commit 7d13e64
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/src/index.js b/src/index.js
@@ -427,18 +427,20 @@ Object.assign(Utils.prototype, {
             .map(l => l.id);
     },
 
-    addVector(id, props) {
+    addVector(id, props, extraProps = {}) {
         if (typeof props === 'string') {
             if (props.match(/\{z\}/)) {
                 return this.addSource(id, {
                     type: 'vector',
                     tiles: [props],
+                    ...extraProps,
                 });
             } else {
                 // mapbox://, http://.../index.json
                 return this.addSource(id, {
                     type: 'vector',
                     url: props,
+                    ...extraProps,
                 });
             }
         } else {

diff --git a/src/index.test.js b/src/index.test.js
@@ -459,6 +459,14 @@ describe('Streamlined addVector', () => {
             url: 'mapbox://foo.blah',
         });
     });
+    test('addVector("mapbox://", { maxzoom: 13 })', () => {
+        map.U.addVector('mysource', 'mapbox://foo.blah', { maxzoom: 13 });
+        expect(map.getStyle().sources['mysource']).toEqual({
+            type: 'vector',
+            url: 'mapbox://foo.blah',
+            maxzoom: 13,
+        });
+    });
     test('addVector("http://tiles.example.com/tiles/{z}/{x}/{y}.pbf")', () => {
         map.U.addVector(
             'mysource',
@@ -469,6 +477,18 @@ describe('Streamlined addVector', () => {
             tiles: ['http://tiles.example.com/tiles/{z}/{x}/{y}.pbf'],
         });
     });
+    test('addVector("http://tiles.example.com/tiles/{z}/{x}/{y}.pbf", { maxzoom: 13 })', () => {
+        map.U.addVector(
+            'mysource',
+            'http://tiles.example.com/tiles/{z}/{x}/{y}.pbf',
+            { maxzoom: 13 }
+        );
+        expect(map.getStyle().sources['mysource']).toEqual({
+            type: 'vector',
+            tiles: ['http://tiles.example.com/tiles/{z}/{x}/{y}.pbf'],
+            maxzoom: 13,
+        });
+    });
 });
 
 describe('Adding layers to a source', () => {