New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test messages to tests which did not have them #50

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@kaoru
Contributor

kaoru commented Mar 28, 2016

Hi Stevan and Yanick,

This is my CPAN Pull Request Challenge PR for March 2016 :-)

I hope the messages I added are accurate. Some of the test cases were a bit hard to wrap my head around, but at the very least they are unique so that if one starts failing it's quick to jump to the right part of the .t file and see what's up.

yanick added a commit that referenced this pull request Mar 28, 2016

merge branch 'pr/50'
- Add test messages to tests which did not have them, (#50, Alex Balhatchet)
@yanick

This comment has been minimized.

Show comment
Hide comment
@yanick

yanick Mar 28, 2016

Collaborator

Merged, thanks!

Collaborator

yanick commented Mar 28, 2016

Merged, thanks!

@yanick yanick closed this Mar 28, 2016

yanick added a commit that referenced this pull request Mar 28, 2016

v0.34
  - Add test messages to tests which did not have them, (#50, Alex
    Balhatchet)

  [ DOCUMENTATION ]
    - add missing module abstracts. (GH#49, Alex Balhatchet, GH#16,
      Sterling Hanenkamp)

  [ ENHANCEMENTS ]
    - SetterInjection can now accept any constructor. (#43, dakkar)

  [ STATISTICS ]
    - code churn: 37 files changed, 462 insertions(+), 395 deletions(-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment