Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few questions. #14

Closed
wants to merge 1 commit into from
Closed

A few questions. #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mop/lib/mop/internal/util.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@ sub INSTALL_FINALIZATION_RUNNER {
# an eval STRING;
|| (caller(3))[3] eq '(eval)';

# Any reason to use private API instead of public here?
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sure I had a reason at one point, but I don't recall it now, so, no, it should use the public API.

push @{ Devel::Hook::_get_unitcheck_array() } => (
sub { mop::module->new( name => $pkg )->run_all_finalizers }
);
Expand Down