Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for overloading #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tobyink
Copy link
Contributor

@tobyink tobyink commented Jul 20, 2013

  • Test cases for overloading, including a TODO (for which I'll file a separate issue).
  • Allow attributes to take part in overloading without needing an accessor. This only makes sense for unary-like overloads.
class Person {
       has $name is overload(q[""]);
}

@doy
Copy link
Collaborator

doy commented Aug 9, 2013

Can you rebase this one too?

@stevan
Copy link
Owner

stevan commented Aug 9, 2013

I can't do it easily (assuming you are talking to me)

On Aug 9, 2013, at 12:17 PM, Jesse Luehrs notifications@github.com wrote:

Can you rebase this one too?


Reply to this email directly or view it on GitHub.

@doy
Copy link
Collaborator

doy commented Aug 9, 2013

I was talking to @tobyink, as it's his pull request(:

@stevan
Copy link
Owner

stevan commented Aug 9, 2013

Actually, I am really not a fan of the overload on attributes.

On Aug 9, 2013, at 12:43 PM, Jesse Luehrs notifications@github.com wrote:

I was talking to @tobyink, as it's his pull request(:


Reply to this email directly or view it on GitHub.

@stevan
Copy link
Owner

stevan commented Aug 9, 2013

Actually, I am okay with this if we explicitly check for unary operators and die on all others.

A test case for ++ and -- would be nice as those are two operators that would maybe make sense for this.

Also maybe %{} and family as well.

On Aug 9, 2013, at 12:45 PM, Stevan Little stevan.little@iinteractive.com wrote:

Actually, I am really not a fan of the overload on attributes.

On Aug 9, 2013, at 12:43 PM, Jesse Luehrs notifications@github.com wrote:

I was talking to @tobyink, as it's his pull request(:


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants