[GSoC] Swift PR #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drexin
reviewed
Aug 12, 2021
| Expr *Arg; | ||
|
|
||
| public: | ||
| PackageAttr(SourceLoc AtLoc, SourceRange Range, |
There was a problem hiding this comment.
Since this has a body, it should be moved into the .cpp file.
There was a problem hiding this comment.
AFAIK simple functions and the main initializer stay in Attr.h?
| @@ -1860,5 +1860,9 @@ ERROR(expected_closure_literal,none, | |||
| ERROR(expected_multiple_closures_block_rbrace,none, | |||
| "expected '}' at the end of a trailing closures block", ()) | |||
|
|
|||
| // Package declaration errors | |||
| ERROR(package_declaration_not_allowed,none, | |||
There was a problem hiding this comment.
This should probably provide a little more detail about why it is not allowed.
There was a problem hiding this comment.
🤔Since this is an experimental feature, we need some flag to allow such syntax, and this error will be thrown if these flags are not specified. I just didn’t come up with a better name?
include/swift/Basic/LangOptions.h
Outdated
| @@ -443,6 +443,12 @@ namespace swift { | |||
| // FrontendOptions. | |||
| bool AllowModuleWithCompilerErrors = false; | |||
|
|
|||
| // Allow @package attribute in the file. | |||
| bool AllowPackageDeclaration = false; | |||
There was a problem hiding this comment.
I think a little more information about when either of these flags should be set would be helpful. Also this should be plural (i.e. Declaration*s*).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.