small typo/gitignore suggestions #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bly shouldn't be checked in.
gobengo
commented
Sep 25, 2023
| @@ -73,7 +73,7 @@ Although it omits numerous details, the following sequence diagram gives an idea | |||
|
|
|||
| ```mermaid | |||
| sequenceDiagram | |||
| box navy Test Suite | |||
There was a problem hiding this comment.
this was because the navy background doesn't render very good on github. see https://github.com/steve-bate/activitypub-testsuite/blob/main/docs/architecture.md#example-test
There was a problem hiding this comment.
Hmm, that's unfortunate. It looks fine when I go to that link but github supports different themes so that may be the issue. It's fine to remove it, it added a small bit of information content (grouping of the sequence actors), but it's not critical.
steve-bate
reviewed
Sep 26, 2023
| @@ -49,6 +49,8 @@ coverage.xml | |||
| *.py,cover | |||
| .hypothesis/ | |||
| .pytest_cache/ | |||
| /.report.json | |||
There was a problem hiding this comment.
It doesn't hurt to add this, but I usually run the tests in the server-specific project.
steve-bate
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey steve. Not sure if you want any of these but figured I'd PR it to suggest.
Thanks for working on this and writing the good thoughtful docs.