Add recommended, additional configuration keys for OCMF #819
Conversation
mhei
force-pushed
the
additional-ocmf-ocpp-config-keys
branch
from
2123cb9
to
085a2c0
Compare
|
hey @mhei thanks for your contribution. i see that you overwrote your commit, but my suggestions are still not part of that. in fact, the new commit looks the same. what changed? |
|
You're right, I just rebased my commit because I saw that you added something about PR and CI interaction; to be honest, I did not see your suggestions nor I received a notification by email... I'd be happy if you could repeat your suggestions again. |
|
oh ok, here is my comment:
|
The OCMF specification by SAFE e.V. recommends in the Best Practices part three new configuration keys for OCPP, see https://github.com/SAFE-eV/OCMF-Open-Charge-Metering-Format/blob/master/OCMF-de.md Add these keys to the list, so that users do not need to enter it manually. It should not harm, since OCPP clients which do not know these keys should handle it gracefully. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
For some items, the listbox is too small to disply the long-ish configuration key name plus a type hint/note. So add a html title property for each listbox item, so that browser show the full string also as tooltip. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
mhei
force-pushed
the
additional-ocmf-ocpp-config-keys
branch
from
085a2c0
to
397011b
Compare
|
thanks @mhei! i will be merging this PR after builds and tests finish. |
The OCMF specification by SAFE e.V. recommends in the Best Practices part
three new configuration keys for OCPP, see
https://github.com/SAFE-eV/OCMF-Open-Charge-Metering-Format/blob/master/OCMF-de.md
Add these keys to the list, so that users do not need to enter it manually.
It should not harm, since OCPP clients which do not know these keys should
handle it gracefully.
Signed-off-by: Michael Heimpold mhei@heimpold.de