Stop constantly recompiling regex in extract_multiple #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, PDL::NiceSlice when used with PDL::LinearAlgebra (a 6700-line file) goes from taking about 10 seconds to be processed using Filter::Simple, to about 0.6s.
The reason is that the regex in
m/\G$func/gcwas constantly being recompiled (in the above case, NYTProf reported it was about 250k times) since$funckept being assigned from$func[$i], i.e. changed. By updating it to be recompiled at the start of the function with the\Gprefixed, then just using the stored version$func[$i], this recompilation is avoided.