Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features Request #25

Closed
tricktux opened this issue Jul 16, 2021 · 5 comments · Fixed by #28
Closed

Features Request #25

tricktux opened this issue Jul 16, 2021 · 5 comments · Fixed by #28
Assignees
Labels
enhancement New feature or request

Comments

@tricktux
Copy link

I would like to start by expressing how excited I am about md2anki. I've followed mdanki for a long time. However, the issue with exports overriding cards, it's truly a deal breaker. Cards, get added and modified all the time. It's truly exciting that you guys were able to fix this issue!

Couple of useful features I would like to request from mdanki are:

  1. Ability to extend card front with %.
  2. Code highlighting

BTW: The latex handling it's pretty awesome.
I've also been following, issue #15

Thanks again for the great work!

@Steve2955
Copy link
Owner

Thank you very much for those kind words. The ability to extend card fronts is on the top of my list as well. However, I intend to use an html-comment syntax for splitting card back and front by default (something like <!-- md2anki split -->). Considering your use case I will add optional compatibility with the mdanki-%-syntax.

I will be working on this as well as #15 on the weekend. I thought about syntax-highlighting for code blocks as well, but that might take some more time.

@Steve2955 Steve2955 self-assigned this Jul 16, 2021
@Steve2955 Steve2955 added the enhancement New feature or request label Jul 16, 2021
@RvNovae
Copy link
Collaborator

RvNovae commented Jul 16, 2021

Perhaps we could use something like https://highlightjs.org/ for syntax highlighting?

  1. Search for code tags in HTML
  2. run that through highlightJS
  3. profit?

@Steve2955
Copy link
Owner

highlightjs is what I had in my mind as well. It's also the recommended way by markdown-it.

@RvNovae Do you might want to implement syntax highlighting? I already did some work on the "extending card fronts"-feature. A PR should be ready for review this evening.

@RvNovae
Copy link
Collaborator

RvNovae commented Jul 16, 2021

highlightjs is what I had in my mind as well. It's also the recommended way by markdown-it.

@RvNovae Do you might want to implement syntax highlighting? I already did some work on the "extending card fronts"-feature. A PR should be ready for review this evening.

Yeah sounds good, I can take a look at it over the weekend.

@tricktux
Copy link
Author

@Steve2955 Thank you much for considering the requests! Really looking forward to that code highlight!

@Steve2955 Steve2955 linked a pull request Jul 18, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants