Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(render): use EOL extmarks to render AerialLine #302

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

folke
Copy link
Contributor

@folke folke commented Oct 12, 2023

I noticed that aerial highlight lines were not always correctly rendered. Especially when using edgy, that resizes component windows automatically.

Looking at the code, I found that to make a line, you used to pad with spaces, but this is not ideal.

Extmarks can be used instead that can extend to the EOL similar to the cursor line.

This PR implements that.

All the highlight_modes should work the same as before, but will now always properly extend till the end of the window when needed.

@stevearc
Copy link
Owner

Wow this was left over from nvim...0.6? 0.5? Thanks for the fix! I'll take a look at the test failure.

While you're here, could I trouble you to take a quick look at folke/neodev.nvim#163?

@folke
Copy link
Contributor Author

folke commented Oct 12, 2023

Thanks for looking into it! :)

Will do some work on neodev soon. Function defs have actually been created in core on nightly, so I will be able to remove some stuff from neodev. But also need to fix some things in core first. Soon!

…buffer, and strict-false still shows it correctly
@folke
Copy link
Contributor Author

folke commented Oct 12, 2023

I think I was able to fix that error. Can't seem to run tests locally, so will wait for the workflow :)

@stevearc
Copy link
Owner

Looks good, thanks!

@stevearc stevearc merged commit 568780e into stevearc:master Oct 12, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants