Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not playing well with rmagatti/goto-preview #38

Closed
joehannes opened this issue Dec 31, 2021 · 2 comments
Closed

Not playing well with rmagatti/goto-preview #38

joehannes opened this issue Dec 31, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@joehannes
Copy link

Describe the bug
I initially reported it with goto-preview, but rmagatti was thinking maybe its due to aerial ...

System information

  • OS: [windows/linux/mac] mac
  • Neovim version:0.7 nightly (v0.7.0-dev+2267-gc46f7caad)
  • AerialInfo: [output of :AerialInfo]
    Aerial Info

Filetype: typescriptreact
Configured backends:
lsp (supported) (attached)
treesitter (not supported)
Show symbols: all symbols

To Reproduce
Steps to reproduce the behavior:

  1. install goto-preview alongside aerial (or use my setup github.com/joehannes-os/neovim-lua-setup
  2. use default goto-preview shortcut to preview definition of a thing in a floating window "gpd" in normal mode with cursor on the thing (eg.: a React Component var ... but not the definition, haha)
  3. see it fail with an aerial error msg

If possible, provide a minimal file that will trigger the issue:

sorry ...

Screenshots
8089FD12-9F1F-45C4-96A1-CC9A56702B78

Additional context
Add any other context about the problem here.

@joehannes joehannes added the bug Something isn't working label Dec 31, 2021
stevearc added a commit that referenced this issue Dec 31, 2021
Not sure exactly the cause, but it seems like we're getting a LSP
symbols callback after the buffer has been deleted.
@stevearc
Copy link
Owner

I couldn't get goto-preview working to repro, so I'm just taking a stab here. I pushed up a change that should hopefully fix the crash. From the trace, it seems like we're getting a LSP symbols callback on a buffer that's invalid (usually means it's been deleted). Not sure why that would happen, but we can guard against it pretty easily. Give the update a try and let me know if that helps

@joehannes
Copy link
Author

yeah @stevearc :-) ... that actually solved the issue!!

C8A79F60-02CF-44A2-BB4F-2D8861EDFA81

hurray

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants