Made driver HTTP request timeouts configurable. #171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
In a recent attempt to make use of this library for a project, I hit a case where the hard coded HTTP request timeout of 3s was holding up project performance due to the driver service (GeoPlugin) blocking my IP and not returning a response.
In this PR, I've made both timeout and connection timeout used in the HttpDriver::http() method configurable in location.php config file. Their default and fallback values remain at 3 seconds as they are in the current master branch.
I believe this change improves this library, by allowing developer more granular control, by setting the maximum time a driver HTTP request is allowed to hold up the execution of the program.
Let me know if any code changes are required to merge this.