Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support specifying hour (e.g. 6:15pm) #1

Open
chdsbd opened this issue Sep 10, 2018 · 1 comment
Open

Support specifying hour (e.g. 6:15pm) #1

chdsbd opened this issue Sep 10, 2018 · 1 comment

Comments

@chdsbd
Copy link

chdsbd commented Sep 10, 2018

Currently, parsing a string like "6:15pm" raises an error. I think it would be nice if this was parsed as 6:15pm, on the day of the base date.

Here is a simple test case:
https://gist.github.com/19557909b3031b176393e74b1dc889c3
@stevedonovan
Copy link
Owner

Yes, that's definitely something I'd like to support....

stevedonovan added a commit that referenced this issue Sep 15, 2018
@stevedonovan
issue #1: support time like 6:15pm
6d2bd19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevedonovan @chdsbd