Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor main BDF reading #5

Closed
GoogleCodeExporter opened this issue Mar 12, 2015 · 4 comments
Closed

refactor main BDF reading #5

GoogleCodeExporter opened this issue Mar 12, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

the FEM_Mesh.py file is a reasonable name if bdf.py didnt exist. bdf.py 
performs mainly card field writing and a better name is probably 
fieldWriter.py. This would then allow FEM_Mesh.py to be replaced with bdf.py 
(rename it).

Futhermore, FEM_Mesh_helper.py is a bad name, and should be split into multiple 
files. Maybe (with the existing approach (FEM_Mesh_addMethods, 
FEM_Mesh_cardBuilder, etc.). This could also be changed to bdf_addMethods, etc.)

Summary:
bdf.py -> fieldWriter.py
FEM_Mesh.py -> bdf.py
FEM_Mesh_helper.py -> bdf_helper.py
bdf_helper.py -> bdf_addMethods.py, bdf_deleteMethods.py, bdf_writeMethods.py, 
cardObject.py

-----------------------------
done:
bdf.py -> fieldWriter.py
FEM_Mesh_helper.py -> bdf_helper.py
bdf_helper.py -> BDF_Card.py

more to come!

Original issue reported on code.google.com by mesheb82 on 17 Oct 2011 at 5:18

@GoogleCodeExporter
Copy link
Author

FEM_Mesh.py now has:
 - Subcase class
 - CaseControlDeck class

pull them out...

Original comment by mesheb82 on 19 Oct 2011 at 6:55

@GoogleCodeExporter
Copy link
Author

done:
FEM_Mesh.py -> subcase.py & caseControlDeck.py
FEM_Mesh.py renamed to bdf.py
FEM_Mesh class renamed to BDF

bdf_helper.py -> bdf_addMethods.py & bdf_writeMesh.py 

consider making BDF_Card a member of BaseCard.  also consider renaming BDF_Card 
to be more consistent

Original comment by mesheb82 on 19 Oct 2011 at 8:10

@GoogleCodeExporter
Copy link
Author

Original comment by mesheb82 on 20 Oct 2011 at 9:19

  • Added labels: Type-Refactor

@GoogleCodeExporter
Copy link
Author

the egregious 2000+ line code is no longer sooo long.  should have closed this 
a while ago

Original comment by mesheb82 on 26 Oct 2011 at 6:04

  • Changed state: Fixed
  • Added labels: Maintainability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant