Rack downgrade, thin upgrade, to co-exist with Rails 3.2 #109
Conversation
…al Rails 3.2 app running on thin.
|
please see readme |
|
Not sure what the readme is supposed to tell me here - I get that it isn't supposed to run "inside" a rails app, but if you've got a gemset for a rails app, you can't install Slanger with the current dependencies. |
|
yep, it's not intended to be inside another application's gemset. it's packaged as a ruby gem only because that is a convenient method of distribution. |
|
Cool - just saw the commentary in #81, explains the position clearer. Can I suggest that the readme be updated to reflect this stance? I feel that the statement about being designed not to run inside Rails isn't as clear as it could be - took this to mean it isn't designed to be mounted/run as an initializer/etc ala: Sidekiq, Resque Web etc. Appreciate your desire to keep it locked down and stand alone, but perhaps a bit more specificity in the readme would help reduce the PRs about gem versioning? |
|
Good idea, it appears it isn't as clear as it needs to be because this class of PR seems to be one of the most frequent. Sorry for not being clearer. |
|
I'm just working on the README now |
|
Wait, sorry, commented on the wrong PR in a different tab. Just to explain: whilst my comment is relevant to this discussion, I thought this was going on right now for a second as I go through and review all the old PRs. |
The default Rails 3.2 with thin installed rack ~> 1.4 and thin ~> 1.5.
Updated gemspec dependencies to happily co-exist with these gems, enabling co-habitation with a Rails gemset.