Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Compatibility #2

Closed
ericmann opened this issue Nov 24, 2015 · 4 comments
Closed

Windows Compatibility #2

ericmann opened this issue Nov 24, 2015 · 4 comments
Assignees
@ericmann
Labels
enhancement help wanted
Milestone
0.2.0

Comments

@ericmann
Copy link
Collaborator

Bash is awesome ... unless you're on a PC ... :-P
@stevegrunwell
Copy link
Owner

Would that be Powershell? Care to volunteer?

@ericmann
Copy link
Collaborator Author

Git can interact with any executable script on the OS. When I do cross-platform stuff, I typically have a .sh (or extensionless) Bash script for *NIX and a .bat script for Windows, both of which bootstrap and execute another, cross-platform, script (like Node, Python, or Ruby).

I'd be happy to take a crack at it, tho.

@stevegrunwell
Copy link
Owner

Awesome, thank you. Also, welcome to the project :)

@ericmann
Copy link
Collaborator Author

So I totally forgot that Git on Windows ships with a version of Cygwin. I've verified that Bash will work as a Git hook on Windows :-)

@stevegrunwell stevegrunwell added this to the 0.2.0 milestone Nov 28, 2015
ericmann added a commit to ericmann/wp-enforcer that referenced this issue Dec 28, 2015
@ericmann
Fix Windows Path Issues
b1a24de 
On Windows (even under MSYS2, which is used by Git), tools like `readlink`
are returing the wrong path and causing the installation routine to fail.
Instead, we can use Composer's native configuration fetcher to figure out
where the bin and vendor directories live.

@todo Find a way around hard-coding the project name in the `DIR`
variable.

Fixes bugs that went unnoticed in stevegrunwell#2.
@ericmann ericmann mentioned this issue Dec 28, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericmann ericmann

Labels
enhancement help wanted
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
2 participants
@stevegrunwell @ericmann