forked from Kitware/CMake
-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cmake: Issue message independent of cmMakefile definition
The makefile is only used when called by the cmMessageCommand, so inline the use of it there. It creates an undesirable dependency on cmMakefile for issuing messages in the cmake instance. This also makes it more explicit that the variable definitions only affect the message() command. If an AUTHOR_WARNING is issued for any other reason, it is not affected. To affect that, it is necessary to set the cache variable instead of the regular variable. This is an unfortunate interface quirk. Perhaps for newly introduced variables, the non-cache version should be ignored to encourage consistency of setting the cache variables instead.
- Loading branch information
Showing
8 changed files
with
51 additions
and
63 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
Tests/RunCMake/message/message-internal-warning-stderr.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
^CMake Warning \(dev\) at message-internal-warning.cmake:3 \(include\): | ||
A logical block opening on the line | ||
|
||
.*Tests/RunCMake/message/message-internal-warning.cmake:4 \(macro\) | ||
|
||
closes on the line | ||
|
||
.*Tests/RunCMake/message/message-internal-warning.cmake:5 \(endmacro\) | ||
|
||
with mis-matching arguments. | ||
Call Stack \(most recent call first\): | ||
CMakeLists.txt:3 \(include\) | ||
This warning is for project developers. Use -Wno-dev to suppress it.$ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
|
||
set(CMAKE_SUPPRESS_DEVELOPER_WARNINGS ON) | ||
|
||
macro(mymacro) | ||
endmacro(notmymacro) |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
|
||
set(CMAKE_SUPPRESS_DEVELOPER_WARNINGS ON CACHE BOOL "") | ||
|
||
macro(mymacro) | ||
endmacro(notmymacro) |