Better debugging information for JIT not compiling

steveklabnik · Feb 25, 2013 · ca6f779 · ca6f779
1 parent f850ace
commit ca6f779
Showing 1 changed file with 22 additions and 28 deletions.
diff --git a/vm/llvm/state.cpp b/vm/llvm/state.cpp
@@ -549,21 +549,14 @@ namespace rubinius {
   {
     bool wait = config().jit_sync;
 
-    // Ignore it!
     if(code->machine_code()->call_count <= 1) {
-      // if(config().jit_inline_debug) {
-        // log() << "JIT: ignoring candidate! "
-          // << symbol_debug_str(code->name()) << "\n";
-      // }
       return;
     }
 
     if(code->machine_code()->compiling_p()) {
       return;
     }
 
-    // Don't do this because it prevents other class from heating
-    // it up too!
     int hits = code->machine_code()->call_count;
     code->machine_code()->set_compiling();
 
@@ -587,15 +580,14 @@ namespace rubinius {
       wait_mutex.unlock();
       gc_dependent();
       state->set_call_frame(0);
-      // if(config().jit_inline_debug) {
+
-        // if(block) {
+      if(state->shared().config.jit_show_compiling) {
-          // log() << "JIT: compiled block inside: "
+        llvm::outs() << "[[[ JIT compiled "
-                // << symbol_debug_str(code->name()) << "\n";
+          << enclosure_name(code) << "#" << symbol_debug_str(code->name())
-        // } else {
+          << (req->is_block() ? " (block) " : " (method) ")
-          // log() << "JIT: compiled method: "
+          << queued_methods() << "/"
-                // << symbol_debug_str(code->name()) << "\n";
+          << jitted_methods() << " ]]]\n";
-        // }
+      }
-      // }
     } else {
       background_thread_->add(req);
 
@@ -626,21 +618,23 @@ namespace rubinius {
             << symbol_debug_str(start->name()) << std::endl;
     }
 
-    // if(config().jit_inline_debug) {
-      // if(start) {
-        // std::cout << "JIT: target search from "
-          // << symbol_debug_str(start->name()) << "\n";
-      // } else {
-        // std::cout << "JIT: target search from primitive\n";
-      // }
-    // }
-
     CallFrame* candidate = find_candidate(state, start, call_frame);
     if(!candidate || candidate->jitted_p() || candidate->inline_method_p()) {
-      if(debug_search) {
+      if(config().jit_show_compiling) {
-        std::cout << "JIT: invalid candidate returned" << std::endl;
+        llvm::outs() << "[[[ JIT error finding call frame "
-      }
+                      << enclosure_name(start) << "#" << symbol_debug_str(start->name());
+        if(!candidate) {
+          llvm::outs() << " no candidate";
+        }
+        if(candidate->jitted_p()) {
+          llvm::outs() << " candidate is jitted";
+        }
+        if(candidate->inline_method_p()) {
+          llvm::outs() << " candidate is inlined";
+        }
 
+        llvm::outs() << " ]]]\n";
+      }
       return;
     }