Documentation Update + Minor Tweaks #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting objects. (Also allow sounds to change URLs after creation)
|
Yay, this great! I guess since this is kept in a different repo it will move separately, but I wanted to flag that the example code in Cloning Tutorial needs to be updated to remove JSON objectives for constructors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main update is to change documentation to no longer use JSON objects for constructors, as per #620 . (I also added some context to Polygon lengths to close #610 )
Various tweaks:
Image Sprites and Sound Objects now have a .url property that behaves like I'd expect (having a get and set property, and setting will update the corresponding media).
Various rotation style stuff was cleaned up (#617 and #618).
My initial investigations and half-fix for #609 are also in this PR, but the errors from that are only marginally better than what we had before (previously it claimed the error was on line 1, now we don't give a line number).