fix min/max() compiling issue when NOMINMAX is predefined #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ implements push-ret based INPLACE scheme to avoid random crash issue if code-cave is modified after api hooking.
only a dest-holder is needed.
- fix a code-cave-pattern (NOP2_RET) too small issue that can corrupt code; (ref: memset.asm)
|
My build env is just windows with msvc so I appreciate you trying other configurations and correcting this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When both and Microsoft's header (Windows.h / WinDefs.h) are included in a same unit, the min/max() will cause compiler issue if NOMINMAX is not defined. (ref: http://www.suodenjoki.dk/us/archive/2010/min-max.htm)
In my use case, I adds a global "/D NOMINMAX" to c++ compiler option to disable the MS min/max macro expansion, otherwise other cross-platform libs using std::min/max() will fail to compile.
When NOMINMAX is globally predefined, we must use std::min/std::max() to explicitly specify that we are using standard algorithm, otherwise c++ compiler cannot resolve min/max unless "using namespace std" is declared.
After this fix is applied, I've verified that my project can build successfully with or without NOMINMAX globally predefined.