- fix vc2019 compiler error for unit-tests;

[randydu]

The vc2019 cannot compile the code (UnitTests\TestDisassembler.cpp) with error C2440:

error C2440: 'initializing': cannot convert from 'initializer list' to 'std::vector<char *,std::allocator<char *>>'
note: No constructor could take the source type, or constructor overload resolution was ambiguous

[stevemk14ebr]

Can you explain how you are building. The project should compile as is without issues with visual studio 2019

[randydu]

I compile the code with warnings as error.

In gcc, the following code compiles with different warning message:

std::vector<char*> samples = { "xxx", "yyy", "zzz"};

warning: ISO C++ forbids converting a string constant to ‘char*’ [-Wwrite-strings]

I got other compiling issues when trying to integrate this project with another master project, which defines NOMINMAX and UNICODE, _UNICODE in global settings.

[stevemk14ebr]

No I mean how exactly are you building, from cmake, via visual studio in cmake mode, via a generated visual studio project, copy and pasting sources/headers into an existing project? Some configurations are supported and some are not

[stevemk14ebr]

Thanks for your contribution, I don't understand why you had these errors, but the changes are valid so thank you.