Fix detour issue on x64 #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ implements push-ret based INPLACE scheme to avoid random crash issue if code-cave is modified after api hooking.
only a dest-holder is needed.
stevemk14ebr
requested changes
Apr 27, 2021
|
If you are able to resolve the two comments I have I will merge your PR quickly. I appreciate your contribution and your drive to find the root cause issue on your own bug! I wish more people did this, model contributor right here! |
- fix a code-cave-pattern (NOP2_RET) too small issue that can corrupt code; (ref: memset.asm)
stevemk14ebr
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It only needs a dest-holder to specify its destination, no extra JMP needed.
the code-cave scheme is a bit slow when hooking many apis, also the code-cave, according to my tests on low memory machine (Win7/x64, 1GB ram), can be modified (or even unmapped from process memory) after hooking, the cave-searching algorithm needs improvement to make sure the code-cave lives in a non-volatile safe place.