Add support for RSD's #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plaplant
reviewed
Jan 17, 2023
There was a problem hiding this comment.
Thanks @steven-murray! Looks great. I didn't look at the packaging/poetry stuff too closely, but I assume it's doing the right thing.
I just have one main comment around how the index/weight computing is being done.
| ---------- | ||
| field | ||
| The original field before displacement. | ||
| dx, dy, dz |
There was a problem hiding this comment.
Is it assumed that the user will provide these "displacement" cubes? Do we document how to calculate this?
|
@plaplant I think this is ready again :-) |
plaplant
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for RSD's.